mm/madvise: remove racy mm ownership check
Jann spotted the security hole due to race of mm ownership check. If the task is sharing the mm_struct but goes through execve() before mm_access(), it could skip process_madvise_behavior_valid check. That makes *any advice hint* to reach into the remote process. This patch removes the mm ownership check. With it, it will lose the ability that local process could give *any* advice hint with vector interface for some reason (e.g., performance). Since there is no concrete example in upstream yet, it would be better to remove the abiliity at this moment and need to review when such new advice comes up. Change-Id: I536de5167b6cf7378a06a6b7815f1dd2869a56a4 Fixes: ecb8ac8b1f14 ("mm/madvise: introduce process_madvise() syscall: an external memory hinting API") Reported-by:Jann Horn <jannh@google.com> Suggested-by:
Jann Horn <jannh@google.com> Signed-off-by:
Minchan Kim <minchan@kernel.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org> Git-Commit: a68a0262abdaa251e12c53715f48e698a18ef402 Git-Repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Signed-off-by:
Charan Teja Reddy <charante@codeaurora.org>
Loading
Please register or sign in to comment