Commit 474f5da2 authored Nov 02, 2017 by Arnd Bergmann Committed by Jens Axboe Nov 02, 2017

skd: use ktime_get_real_seconds()



Like many storage drivers, skd uses an unsigned 32-bit number for
interchanging the current time with the firmware. This will overflow in
y2106 and is otherwise safe.

However, the get_seconds() function is generally considered deprecated
since the behavior is different between 32-bit and 64-bit architectures,
and using it may indicate a bigger problem.

To annotate that we've thought about this, let's add a comment here
and migrate to the ktime_get_real_seconds() function that consistently
returns a 64-bit number.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent c091fbe9

drivers/block/skd_main.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1967,7 +1967,8 @@ static void skd_isr_msg_from_dev(struct skd_device *skdev)
	break;		break;

	case FIT_MTD_CMD_LOG_HOST_ID:		case FIT_MTD_CMD_LOG_HOST_ID:
	skdev->connect_time_stamp = get_seconds();		/* hardware interface overflows in y2106 */
			skdev->connect_time_stamp = (u32)ktime_get_real_seconds();
	data = skdev->connect_time_stamp & 0xFFFF;		data = skdev->connect_time_stamp & 0xFFFF;
	mtd = FIT_MXD_CONS(FIT_MTD_CMD_LOG_TIME_STAMP_LO, 0, data);		mtd = FIT_MXD_CONS(FIT_MTD_CMD_LOG_TIME_STAMP_LO, 0, data);
	SKD_WRITEL(skdev, mtd, FIT_MSG_TO_DEVICE);		SKD_WRITEL(skdev, mtd, FIT_MSG_TO_DEVICE);