Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47265c06 authored by Grigor Tovmasyan's avatar Grigor Tovmasyan Committed by Felipe Balbi
Browse files

usb: dwc2: gadget: Fix coverity issue 



When _param is unsigned and the minimum value of range is 0, it gives
the following warning:
COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value
is never true.

Converting ._param to int to avoid this warning.

Signed-off-by: default avatarGrigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 8223b2f8

drivers/usb/dwc2/params.c

+1 −1
Original line number Diff line number Diff line
@@ -556,7 +556,7 @@ static void dwc2_check_param_tx_fifo_sizes(struct dwc2_hsotg *hsotg) 
}



#define CHECK_RANGE(_param, _min, _max, _def) do {			\

		if ((hsotg->params._param) < (_min) ||			\

		if ((int)(hsotg->params._param) < (_min) ||		\

		    (hsotg->params._param) > (_max)) {			\

			dev_warn(hsotg->dev, "%s: Invalid parameter %s=%d\n", \

				 __func__, #_param, hsotg->params._param); \