Commit 4720725e authored Nov 24, 2022 by Yuan Can Committed by Greg Kroah-Hartman Dec 08, 2022

net: net_netdev: Fix error handling in ntb_netdev_init_module()



[ Upstream commit b8f79dccd38edf7db4911c353d9cd792ab13a327 ]

The ntb_netdev_init_module() returns the ntb_transport_register_client()
directly without checking its return value, if
ntb_transport_register_client() failed, the NTB client device is not
unregistered.

Fix by unregister NTB client device when ntb_transport_register_client()
failed.

Fixes: 548c237c ("net: Add support for NTB virtual ethernet device")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 3e21f85d

drivers/net/ntb_netdev.c

+8 −1

Original line number	Original line	Diff line number	Diff line
	@@ -484,7 +484,14 @@ static int __init ntb_netdev_init_module(void)
	rc = ntb_transport_register_client_dev(KBUILD_MODNAME);		rc = ntb_transport_register_client_dev(KBUILD_MODNAME);
	if (rc)		if (rc)
	return rc;		return rc;
	return ntb_transport_register_client(&ntb_netdev_client);
			rc = ntb_transport_register_client(&ntb_netdev_client);
			if (rc) {
			ntb_transport_unregister_client_dev(KBUILD_MODNAME);
			return rc;
			}

			return 0;
	}		}
	module_init(ntb_netdev_init_module);		module_init(ntb_netdev_init_module);