Commit 471c5335 authored Jun 27, 2024 by Alex Hung Committed by Greg Kroah-Hartman Nov 08, 2024

drm/amd/display: Check stream before comparing them



[ Upstream commit 35ff747c86767937ee1e0ca987545b7eed7a0810 ]

[WHAT & HOW]
amdgpu_dm can pass a null stream to dc_is_stream_unchanged. It is
necessary to check for null before dereferencing them.

This fixes 1 FORWARD_NULL issue reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dac398ed

drivers/gpu/drm/amd/display/dc/core/dc_resource.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1542,6 +1542,8 @@ static bool are_stream_backends_same(
		bool dc_is_stream_unchanged(
		struct dc_stream_state old_stream, struct dc_stream_state stream)
		{
		if (!old_stream \|\| !stream)
		return false;

		if (!are_stream_backends_same(old_stream, stream))
		return false;