Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46f54582 authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

mmc: cavium-thunderx: Add of_node_put() when breaking out of loop 



[ Upstream commit 7ee480795e41db314f2c445c65ed854a5d6e8e32 ]

In thunder_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.

Fixes: 166bac38 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")
Signed-off-by: default avatarLiang He <windhl@126.com>
Acked-by: default avatarRobert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-2-windhl@126.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d0cc1ba2

drivers/mmc/host/cavium-thunderx.c

+3 −1
Original line number Diff line number Diff line
@@ -138,9 +138,11 @@ static int thunder_mmc_probe(struct pci_dev *pdev, 
				continue;



			ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);

			if (ret)

			if (ret) {

				of_node_put(child_node);

				goto error;

			}

		}

		i++;

	}

	dev_info(dev, "probed\n");