Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46e66619 authored by Steve French's avatar Steve French
Browse files

SMB3: Add handling for different FSCTL access flags 



DesiredAccess field in SMB3 open request needs
to be set differently for READ vs. WRITE ioctls
(not just ones that request both).

Originally noticed by Pavel

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
parent efac779b

fs/cifs/smb2ops.c

+9 −1
Original line number Diff line number Diff line
@@ -1389,7 +1389,15 @@ smb2_ioctl_query_info(const unsigned int xid, 
		switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {

		case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:

			oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;

			;

			break;

		case FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS:

			oparms.desired_access = GENERIC_ALL;

			break;

		case FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS:

			oparms.desired_access = GENERIC_READ;

			break;

		case FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS:

			oparms.desired_access = GENERIC_WRITE;

			break;

		}

	}