Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46574e5a authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk 



commit 832e231cff476102e8204a9e7bddfe5c6154a375 upstream.

When the best clk is searched, we iterate over all possible clk.

If we find a better match, the previous one, if any, needs to be freed.
If a better match has already been found, we still need to free the new
one, otherwise it leaks.

Cc: <stable@vger.kernel.org> # v3.3+
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Fixes: 5f5a7a55 ("serial: samsung: switch to clkdev based clock lookup")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Message-ID: <cf3e0053d2fc7391b2d906a86cd01a5ef15fb9dc.1686412569.git.christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 30962268

drivers/tty/serial/samsung.c

+8 −0
Original line number Diff line number Diff line
@@ -1230,10 +1230,18 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport, 
			calc_deviation = -calc_deviation;



		if (calc_deviation < deviation) {

			/*

			 * If we find a better clk, release the previous one, if

			 * any.

			 */

			if (!IS_ERR(*best_clk))

				clk_put(*best_clk);

			*best_clk = clk;

			best_quot = quot;

			*clk_num = cnt;

			deviation = calc_deviation;

		} else {

			clk_put(clk);

		}

	}