Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45dc488c authored by Mike Christie's avatar Mike Christie Committed by Nicholas Bellinger
Browse files

tcmu: fix cmd user after free 



If we are failing the command due to a qfull timeout we are
also freeing the tcmu command, so we cannot access it later
to get the se_cmd.

Note: The clearing of cmd->se_cmd is not needed. We do not check
it later for something like determining if the command was failed
due to a timeout. As a result I am dropping it.

Signed-off-by: default avatarMike Christie <mchristi@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent c82b59e7

drivers/target/target_core_user.c

+1 −2
Original line number Diff line number Diff line
@@ -1152,6 +1152,7 @@ static int tcmu_check_expired_cmd(int id, void *p, void *data) 
		return 0;



	is_running = list_empty(&cmd->cmdr_queue_entry);

	se_cmd = cmd->se_cmd;



	if (is_running) {

		/*
@@ -1177,8 +1178,6 @@ static int tcmu_check_expired_cmd(int id, void *p, void *data) 
	pr_debug("Timing out cmd %u on dev %s that is %s.\n",

		 id, udev->name, is_running ? "inflight" : "queued");



	se_cmd = cmd->se_cmd;

	cmd->se_cmd = NULL;

	target_complete_cmd(se_cmd, scsi_status);

	return 0;

}