Commit 458ffce1 authored Nov 08, 2018 by Neil Armstrong Committed by Mauro Carvalho Chehab Dec 03, 2018

media: cxd2880-spi: fix probe when dvb_attach fails

When dvb_attach fails, probe returns 0, and remove crashes afterwards.
This patch sets the return value to -ENODEV when attach fails.

Fixes: bd24fcdd ("media: cxd2880-spi: Add support for CXD2880 SPI interface")

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent bac26a63

drivers/media/spi/cxd2880-spi.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -536,6 +536,7 @@ cxd2880_spi_probe(struct spi_device *spi)

		if (!dvb_attach(cxd2880_attach, &dvb_spi->dvb_fe, &config)) {
		pr_err("cxd2880_attach failed\n");
		ret = -ENODEV;
		goto fail_attach;
		}