Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45128b08 authored by zhong jiang's avatar zhong jiang Committed by David Sterba
Browse files

btrfs: change btrfs_pin_log_trans to return void 



btrfs_pin_log_trans defines the variable "ret" for return value, but it
is not modified after initialization. Further, I find that none of the
callers do handles the return value, so it is safe to drop the unneeded
"ret" and make it return void.

Signed-off-by: default avatarzhong jiang <zhongjiang@huawei.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 556f3ca8

fs/btrfs/tree-log.c

+1 −4
Original line number Diff line number Diff line
@@ -205,14 +205,11 @@ static int join_running_log_trans(struct btrfs_root *root) 
 * until you call btrfs_end_log_trans() or it makes any future

 * log transactions wait until you call btrfs_end_log_trans()

 */

int btrfs_pin_log_trans(struct btrfs_root *root)

void btrfs_pin_log_trans(struct btrfs_root *root)

{

	int ret = -ENOENT;



	mutex_lock(&root->log_mutex);

	atomic_inc(&root->log_writers);

	mutex_unlock(&root->log_mutex);

	return ret;

}



/*

fs/btrfs/tree-log.h

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ int btrfs_del_inode_ref_in_log(struct btrfs_trans_handle *trans, 
			       const char *name, int name_len,

			       struct btrfs_inode *inode, u64 dirid);

void btrfs_end_log_trans(struct btrfs_root *root);

int btrfs_pin_log_trans(struct btrfs_root *root);

void btrfs_pin_log_trans(struct btrfs_root *root);

void btrfs_record_unlink_dir(struct btrfs_trans_handle *trans,

			     struct btrfs_inode *dir, struct btrfs_inode *inode,

			     int for_rename);