Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44eb385b authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller
Browse files

octeontx2-af: remove unused cgx_fwi_link_change 



The newly added driver causes a warning about a function that is
not used anywhere:

drivers/net/ethernet/marvell/octeontx2/af/cgx.c:320:12: error: 'cgx_fwi_link_change' defined but not used [-Werror=unused-function]

Remove it for now, until a user gets added. If we want to use this
function from another module, we also need a declaration in a header
file, which is currently missing, so it would have to change anyway.

Fixes: 1463f382 ("octeontx2-af: Add support for CGX link management")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5948185b

drivers/net/ethernet/marvell/octeontx2/af/cgx.c

+0 −17
Original line number Diff line number Diff line
@@ -58,9 +58,6 @@ struct cgx { 


static LIST_HEAD(cgx_list);



/* CGX PHY management internal APIs */

static int cgx_fwi_link_change(struct cgx *cgx, int lmac_id, bool en);



/* Supported devices */

static const struct pci_device_id cgx_id_table[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX2_CGX) },
@@ -317,20 +314,6 @@ int cgx_lmac_evh_register(struct cgx_event_cb *cb, void *cgxd, int lmac_id) 
}

EXPORT_SYMBOL(cgx_lmac_evh_register);



static int cgx_fwi_link_change(struct cgx *cgx, int lmac_id, bool enable)

{

	u64 req = 0;

	u64 resp;



	if (enable)

		req = FIELD_SET(CMDREG_ID, CGX_CMD_LINK_BRING_UP, req);

	else

		req = FIELD_SET(CMDREG_ID, CGX_CMD_LINK_BRING_DOWN, req);



	return cgx_fwi_cmd_generic(req, &resp, cgx, lmac_id);

}

EXPORT_SYMBOL(cgx_fwi_link_change);



static inline int cgx_fwi_read_version(u64 *resp, struct cgx *cgx)

{

	u64 req = 0;