Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 449a705f authored by Maxim Devaev's avatar Maxim Devaev Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_hid: idle uses the highest byte for duration 



commit fa20bada3f934e3b3e4af4c77e5b518cd5a282e5 upstream.

SET_IDLE value must be shifted 8 bits to the right to get duration.
This confirmed by USBCV test.

Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarMaxim Devaev <mdevaev@gmail.com>
Link: https://lore.kernel.org/r/20210727185800.43796-1-mdevaev@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 02f336ce

drivers/usb/gadget/function/f_hid.c

+1 −1
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ static int hidg_setup(struct usb_function *f, 
		  | HID_REQ_SET_IDLE):

		VDBG(cdev, "set_idle\n");

		length = 0;

		hidg->idle = value;

		hidg->idle = value >> 8;

		goto respond;

		break;