Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44937456 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman
Browse files

drm: msm: fix possible memory leak in mdp5_crtc_cursor_set() 



[ Upstream commit 947a844bb3ebff0f4736d244d792ce129f6700d7 ]

drm_gem_object_lookup will call drm_gem_object_get inside. So cursor_bo
needs to be put when msm_gem_get_and_pin_iova fails.

Fixes: e172d10a ("drm/msm/mdp5: Add hardware cursor support")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220509061125.18585-1-hbh25y@gmail.com


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6832e36f

drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c

+3 −1
Original line number Diff line number Diff line
@@ -909,8 +909,10 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc, 


	ret = msm_gem_get_and_pin_iova(cursor_bo, kms->aspace,

			&mdp5_crtc->cursor.iova);

	if (ret)

	if (ret) {

		drm_gem_object_put(cursor_bo);

		return -EINVAL;

	}



	pm_runtime_get_sync(&pdev->dev);