Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 448a2413 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

Revert "r8169: use netif_receive_skb_list batching" 

This reverts commit 6578229d.
netif_receive_skb_list() doesn't support GRO, therefore we may have
scenarios with decreased performance. See discussion here [0].

[0] https://marc.info/?t=155403847400001&r=1&w=2



Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6fee16d

drivers/net/ethernet/realtek/r8169.c

+1 −4
Original line number Diff line number Diff line
@@ -6426,7 +6426,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget 
{

	unsigned int cur_rx, rx_left;

	unsigned int count;

	LIST_HEAD(rx_list);



	cur_rx = tp->cur_rx;
@@ -6502,7 +6501,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget 
			if (skb->pkt_type == PACKET_MULTICAST)

				dev->stats.multicast++;



			list_add_tail(&skb->list, &rx_list);

			napi_gro_receive(&tp->napi, skb);



			u64_stats_update_begin(&tp->rx_stats.syncp);

			tp->rx_stats.packets++;
@@ -6517,8 +6516,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget 
	count = cur_rx - tp->cur_rx;

	tp->cur_rx = cur_rx;



	netif_receive_skb_list(&rx_list);



	return count;

}