Commit 4467e29f authored Nov 09, 2015 by Yaowei Bai Committed by Linus Torvalds Nov 09, 2015

fs/ncpfs/dir.c: remove unnecessary new_valid_dev() check



new_valid_dev() always returns 1, so the !new_valid_dev() check is not
needed.  Remove it.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Petr Vandrovec <petr@vandrovec.name>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@fb.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a2a17044

fs/ncpfs/dir.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1165,8 +1165,6 @@ static int ncp_rename(struct inode old_dir, struct dentry old_dentry,
		static int ncp_mknod(struct inode * dir, struct dentry *dentry,
		umode_t mode, dev_t rdev)
		{
		if (!new_valid_dev(rdev))
		return -EINVAL;
		if (ncp_is_nfs_extras(NCP_SERVER(dir), NCP_FINFO(dir)->volNumber)) {
		ncp_dbg(1, "mode = 0%ho\n", mode);
		return ncp_create_new(dir, dentry, mode, rdev, 0);