Commit 440f895a authored Sep 11, 2016 by Christophe Jaillet Committed by David S. Miller Sep 13, 2016

drivers: net: phy: xgene: Fix 'remove' function



If 'IS_ERR(pdata->clk)' is true, then 'clk_disable_unprepare(pdata->clk)'
will do nothing.

It is likely that 'if (!IS_ERR(pdata->clk))' was expected here.
In fact, the test can even be removed because 'clk_disable_unprepare'
already handles such cases.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 715f5552

drivers/net/phy/mdio-xgene.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -424,10 +424,8 @@ static int xgene_mdio_remove(struct platform_device *pdev)
		mdiobus_unregister(mdio_bus);
		mdiobus_free(mdio_bus);

		if (dev->of_node) {
		if (IS_ERR(pdata->clk))
		if (dev->of_node)
		clk_disable_unprepare(pdata->clk);
		}

		return 0;
		}