Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43f1402d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

mtd: rawnand: ingenic: fix empty stub helper definitions 



[ Upstream commit 650a8884a364ff2568b51cde9009cfd43cdae6ad ]

A few functions provide an empty interface definition when
CONFIG_MTD_NAND_INGENIC_ECC is disabled, but they are accidentally
defined as global functions in the header:

drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:39:5: error: no previous prototype for 'ingenic_ecc_calculate'
drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:46:5: error: no previous prototype for 'ingenic_ecc_correct'
drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:53:6: error: no previous prototype for 'ingenic_ecc_release'
drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:57:21: error: no previous prototype for 'of_ingenic_ecc_get'

Turn them into 'static inline' definitions instead.

Fixes: 15de8c6e ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230516202133.559488-1-arnd@kernel.org


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent dd3773e8

drivers/mtd/nand/raw/ingenic/ingenic_ecc.h

+4 −4
Original line number Original line Diff line number Diff line
@@ -36,25 +36,25 @@ int ingenic_ecc_correct(struct ingenic_ecc *ecc, 
void ingenic_ecc_release(struct ingenic_ecc *ecc);

void ingenic_ecc_release(struct ingenic_ecc *ecc);

struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *np);

struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *np);

#else /* CONFIG_MTD_NAND_INGENIC_ECC */

#else /* CONFIG_MTD_NAND_INGENIC_ECC */

int ingenic_ecc_calculate(struct ingenic_ecc *ecc,

static inline int ingenic_ecc_calculate(struct ingenic_ecc *ecc,

			  struct ingenic_ecc_params *params,

			  struct ingenic_ecc_params *params,

			  const u8 *buf, u8 *ecc_code)

			  const u8 *buf, u8 *ecc_code)

{

{

	return -ENODEV;

	return -ENODEV;

}

}





int ingenic_ecc_correct(struct ingenic_ecc *ecc,

static inline int ingenic_ecc_correct(struct ingenic_ecc *ecc,

			struct ingenic_ecc_params *params, u8 *buf,

			struct ingenic_ecc_params *params, u8 *buf,

			u8 *ecc_code)

			u8 *ecc_code)

{

{

	return -ENODEV;

	return -ENODEV;

}

}





void ingenic_ecc_release(struct ingenic_ecc *ecc)

static inline void ingenic_ecc_release(struct ingenic_ecc *ecc)

{

{

}

}





struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *np)

static inline struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *np)

{

{

	return ERR_PTR(-ENODEV);

	return ERR_PTR(-ENODEV);

}

}