Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 439c71f7 authored by Sasha Neftin's avatar Sasha Neftin Committed by Jeff Kirsher
Browse files

igc: Remove unneeded code 



Remove the 'igc_get_link_up_info_base method' from igc_base.c file.
Use the 'igc_get_speed_and_duplex_copper' method directly and reduce
the code redundancy.

Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 55fdbeaa

drivers/net/ethernet/intel/igc/igc_base.c

+1 −21
Original line number Diff line number Diff line
@@ -333,26 +333,6 @@ static void igc_release_phy_base(struct igc_hw *hw) 
	hw->mac.ops.release_swfw_sync(hw, mask);

}



/**

 * igc_get_link_up_info_base - Get link speed/duplex info

 * @hw: pointer to the HW structure

 * @speed: stores the current speed

 * @duplex: stores the current duplex

 *

 * This is a wrapper function, if using the serial gigabit media independent

 * interface, use PCS to retrieve the link speed and duplex information.

 * Otherwise, use the generic function to get the link speed and duplex info.

 */

static s32 igc_get_link_up_info_base(struct igc_hw *hw, u16 *speed,

				     u16 *duplex)

{

	s32 ret_val;



	ret_val = igc_get_speed_and_duplex_copper(hw, speed, duplex);



	return ret_val;

}



/**

 * igc_init_hw_base - Initialize hardware

 * @hw: pointer to the HW structure
@@ -499,7 +479,7 @@ static struct igc_mac_operations igc_mac_ops_base = { 
	.check_for_link		= igc_check_for_copper_link,

	.rar_set		= igc_rar_set,

	.read_mac_addr		= igc_read_mac_addr_base,

	.get_speed_and_duplex	= igc_get_link_up_info_base,

	.get_speed_and_duplex	= igc_get_speed_and_duplex_copper,

};



static const struct igc_phy_operations igc_phy_ops_base = {