Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4398e705 authored by Oded Gabbay's avatar Oded Gabbay Committed by Greg Kroah-Hartman
Browse files

habanalabs: return error when failing to read/write i2c 



The driver can't read/write from i2c if the device is in reset or
disabled. Therefore, return -EBUSY in those cases instead of 0.

This change also fixes a smatch warning about uninitialized variable.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8737d037

drivers/misc/habanalabs/debugfs.c

+2 −2
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ static int hl_debugfs_i2c_read(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr, 
	int rc;



	if (hl_device_disabled_or_in_reset(hdev))

		return 0;

		return -EBUSY;



	memset(&pkt, 0, sizeof(pkt));
@@ -50,7 +50,7 @@ static int hl_debugfs_i2c_write(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr, 
	int rc;



	if (hl_device_disabled_or_in_reset(hdev))

		return 0;

		return -EBUSY;



	memset(&pkt, 0, sizeof(pkt));