Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 434ca100 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Dmitry Torokhov
Browse files

Input: yealink - replace GFP_ATOMIC with GFP_KERNEL in usb_probe() 



usb_probe() is never called in atomic context.  It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary.  GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 1f25d9c6

drivers/input/misc/yealink.c

+2 −2
Original line number Diff line number Diff line
@@ -894,12 +894,12 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) 


	/* allocate usb buffers */

	yld->irq_data = usb_alloc_coherent(udev, USB_PKT_LEN,

					   GFP_ATOMIC, &yld->irq_dma);

					   GFP_KERNEL, &yld->irq_dma);

	if (yld->irq_data == NULL)

		return usb_cleanup(yld, -ENOMEM);



	yld->ctl_data = usb_alloc_coherent(udev, USB_PKT_LEN,

					   GFP_ATOMIC, &yld->ctl_dma);

					   GFP_KERNEL, &yld->ctl_dma);

	if (!yld->ctl_data)

		return usb_cleanup(yld, -ENOMEM);