Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43240bbd authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Thierry Reding
Browse files

gpu: host1x: At first try a non-blocking allocation for the gather copy 



The blocking gather copy allocation is a major performance downside of the
Host1x firewall, it may take hundreds milliseconds which is unacceptable
for the real-time graphics operations. Let's try a non-blocking allocation
first as a least invasive solution, it makes opentegra (Xorg driver)
performance indistinguishable with/without the firewall.

Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarErik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 8474b025

drivers/gpu/host1x/job.c

+12 −4
Original line number Diff line number Diff line
@@ -574,12 +574,20 @@ static inline int copy_gathers(struct host1x_job *job, struct device *dev) 
		size += g->words * sizeof(u32);

	}



	/*

	 * Try a non-blocking allocation from a higher priority pools first,

	 * as awaiting for the allocation here is a major performance hit.

	 */

	job->gather_copy_mapped = dma_alloc_wc(dev, size, &job->gather_copy,

					       GFP_NOWAIT);



	/* the higher priority allocation failed, try the generic-blocking */

	if (!job->gather_copy_mapped)

		job->gather_copy_mapped = dma_alloc_wc(dev, size,

						       &job->gather_copy,

						       GFP_KERNEL);

	if (!job->gather_copy_mapped) {

		job->gather_copy_mapped = NULL;

	if (!job->gather_copy_mapped)

		return -ENOMEM;

	}



	job->gather_copy_size = size;