Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42fa5e0e authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: warn on invalid statistics size 



Getting the wrong statistics size is a problem, having a warning
will help us catch it quicker during firmware/driver development.
In released firmware/driver versions, we obviously make sure this
won't happen.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 1184611e

drivers/net/wireless/intel/iwlwifi/mvm/rx.c

+3 −4
Original line number Diff line number Diff line
@@ -661,11 +661,10 @@ void iwl_mvm_handle_rx_statistics(struct iwl_mvm *mvm, 
		expected_size = sizeof(struct iwl_notif_statistics_cdb);

	}



	if (iwl_rx_packet_payload_len(pkt) != expected_size) {

		IWL_ERR(mvm, "received invalid statistics size (%d)!\n",

			iwl_rx_packet_payload_len(pkt));

	if (WARN_ONCE(iwl_rx_packet_payload_len(pkt) != expected_size,

		      "received invalid statistics size (%d)!\n",

		      iwl_rx_packet_payload_len(pkt)))

		return;

	}



	if (!iwl_mvm_has_new_rx_stats_api(mvm)) {

		struct iwl_notif_statistics_v11 *stats = (void *)&pkt->data;