Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42ecda1a authored by Julia Lawall's avatar Julia Lawall Committed by Ralf Baechle
Browse files

MIPS: Alchemy: Correct code taking the size of a pointer 

sizeof(dp) is just the size of the pointer.  Change it to the size of the
referenced structure.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression *x;
expression f;
type T;
@@

*f(...,(T)x,...)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Patchwork: http://patchwork.linux-mips.org/patch/789/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 05c69468

arch/mips/alchemy/common/dbdma.c

+2 −2
Original line number Diff line number Diff line
@@ -613,7 +613,7 @@ u32 _au1xxx_dbdma_put_source(u32 chanid, void *buf, int nbytes, u32 flags) 
	dma_cache_wback_inv((unsigned long)buf, nbytes);

	dp->dscr_cmd0 |= DSCR_CMD0_V;	/* Let it rip */

	au_sync();

	dma_cache_wback_inv((unsigned long)dp, sizeof(dp));

	dma_cache_wback_inv((unsigned long)dp, sizeof(*dp));

	ctp->chan_ptr->ddma_dbell = 0;



	/* Get next descriptor pointer.	*/
@@ -676,7 +676,7 @@ _au1xxx_dbdma_put_dest(u32 chanid, void *buf, int nbytes, u32 flags) 
	dma_cache_inv((unsigned long)buf, nbytes);

	dp->dscr_cmd0 |= DSCR_CMD0_V;	/* Let it rip */

	au_sync();

	dma_cache_wback_inv((unsigned long)dp, sizeof(dp));

	dma_cache_wback_inv((unsigned long)dp, sizeof(*dp));

	ctp->chan_ptr->ddma_dbell = 0;



	/* Get next descriptor pointer.	*/