Commit 42cc6886 authored May 04, 2019 by Wei Yongjun Committed by Felipe Balbi Jun 06, 2019

usb: gadget: udc: lpc32xx: fix return value check in lpc32xx_udc_probe()



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

This issue was detected by using the Coccinelle software.

Fixes: 408b56ca ("usb: gadget: udc: lpc32xx: simplify probe")
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 066cfd07

drivers/usb/gadget/udc/lpc32xx_udc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3069,9 +3069,9 @@ static int lpc32xx_udc_probe(struct platform_device *pdev)
		}

		udc->udp_baseaddr = devm_ioremap_resource(dev, res);
		if (!udc->udp_baseaddr) {
		if (IS_ERR(udc->udp_baseaddr)) {
		dev_err(udc->dev, "IO map failure\n");
		return -ENOMEM;
		return PTR_ERR(udc->udp_baseaddr);
		}

		/* Get USB device clock */