Commit 429370c4 authored Dec 07, 2022 by Zhang Changzhong Committed by Greg Kroah-Hartman Jan 18, 2023

net: stmmac: selftests: fix potential memleak in stmmac_test_arpoffload()



[ Upstream commit f150b63f3fa5fdd81e0dd6151e8850268e29438c ]

The skb allocated by stmmac_test_get_arp_skb() hasn't been released in
some error handling case, which will lead to a memory leak. Fix this up
by adding kfree_skb() to release skb.

Compile tested only.

Fixes: 5e3fb0a6 ("net: stmmac: selftests: Implement the ARP Offload test")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bba527e4

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1614,12 +1614,16 @@ static int stmmac_test_arpoffload(struct stmmac_priv *priv)
		}

		ret = stmmac_set_arp_offload(priv, priv->hw, true, ip_addr);
		if (ret)
		if (ret) {
		kfree_skb(skb);
		goto cleanup;
		}

		ret = dev_set_promiscuity(priv->dev, 1);
		if (ret)
		if (ret) {
		kfree_skb(skb);
		goto cleanup;
		}

		skb_set_queue_mapping(skb, 0);
		ret = dev_queue_xmit(skb);