Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42687543 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: Use enums instead of magic number in hclge_is_special_opcode 



This patch does bit of a clean-up by using already defined enums for
certain values in function hclge_is_special_opcode(). Below enums from
have been used as replacements for magic values:

enum hclge_opcode_type{
	<snip>
	HCLGE_OPC_STATS_64_BIT		= 0x0030,
	HCLGE_OPC_STATS_32_BIT		= 0x0031,
	HCLGE_OPC_STATS_MAC		= 0x0032,
	<snip>
};

Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3c7624d8

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

+5 −1
Original line number Diff line number Diff line
@@ -190,7 +190,11 @@ static int hclge_cmd_csq_done(struct hclge_hw *hw) 


static bool hclge_is_special_opcode(u16 opcode)

{

	u16 spec_opcode[3] = {0x0030, 0x0031, 0x0032};

	/* these commands have several descriptors,

	 * and use the first one to save opcode and return value

	 */

	u16 spec_opcode[3] = {HCLGE_OPC_STATS_64_BIT,

		HCLGE_OPC_STATS_32_BIT, HCLGE_OPC_STATS_MAC};

	int i;



	for (i = 0; i < ARRAY_SIZE(spec_opcode); i++) {