Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 424f73b3 authored by Heiko Carstens's avatar Heiko Carstens Committed by David S. Miller
Browse files

lcs: get rid of compile warning 



-Wunused-but-set-variable generates a compile warning for lcs' tasklet
function. Invoked functions contain already error handling; thus
additional return code checking is not needed here.

Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarFrank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38ed18ff

drivers/s390/net/lcs.c

+3 −7
Original line number Diff line number Diff line
@@ -1483,7 +1483,6 @@ lcs_tasklet(unsigned long data) 
	struct lcs_channel *channel;

	struct lcs_buffer *iob;

	int buf_idx;

	int rc;



	channel = (struct lcs_channel *) data;

	LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev));
@@ -1500,14 +1499,11 @@ lcs_tasklet(unsigned long data) 
	channel->buf_idx = buf_idx;



	if (channel->state == LCS_CH_STATE_STOPPED)

		// FIXME: what if rc != 0 ??

		rc = lcs_start_channel(channel);

		lcs_start_channel(channel);

	spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags);

	if (channel->state == LCS_CH_STATE_SUSPENDED &&

	    channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY) {

		// FIXME: what if rc != 0 ??

		rc = __lcs_resume_channel(channel);

	}

	    channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY)

		__lcs_resume_channel(channel);

	spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags);



	/* Something happened on the channel. Wake up waiters. */