Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41f2c6e8 authored by Alessio Igor Bogani's avatar Alessio Igor Bogani Committed by Greg Kroah-Hartman
Browse files

USB: sisusbvga: Remove the BKL from ioctl 



Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.

Also change the returned value to long.

Signed-off-by: default avatarAlessio Igor Bogani <abogani@texware.it>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent d20db4b4

drivers/usb/misc/sisusbvga/sisusb.c

+1 −3
Original line number Diff line number Diff line
@@ -2974,13 +2974,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
	struct sisusb_usb_data *sisusb;

	struct sisusb_info x;

	struct sisusb_command y;

	int	retval = 0;

	long retval = 0;

	u32 __user *argp = (u32 __user *)arg;



	if (!(sisusb = (struct sisusb_usb_data *)file->private_data))

		return -ENODEV;



	lock_kernel();

	mutex_lock(&sisusb->lock);



	/* Sanity check */
@@ -3039,7 +3038,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 


err_out:

	mutex_unlock(&sisusb->lock);

	unlock_kernel();

	return retval;

}