Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 41e486f4 authored by Paul Burton's avatar Paul Burton
Browse files

MIPS: Remove struct mm_context_t fp_mode_switching field 



The fp_mode_switching field in struct mm_context_t was left unused by
commit 8c8d953c ("MIPS: Schedule on CPUs we need to lose FPU for a
mode switch") in v4.19, with nothing modifying its value & nothing
waiting on it having any particular value after that commit. Remove the
unused field & the one remaining reference to it.

Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
parent 99bf73eb

arch/mips/include/asm/mmu.h

+0 −1
Original line number Diff line number Diff line
@@ -9,7 +9,6 @@ 
typedef struct {

	u64 asid[NR_CPUS];

	void *vdso;

	atomic_t fp_mode_switching;



	/* lock to be held whilst modifying fp_bd_emupage_allocmap */

	spinlock_t bd_emupage_lock;

arch/mips/kernel/process.c

+3 −6
Original line number Diff line number Diff line
@@ -737,10 +737,9 @@ static long prepare_for_fp_mode_switch(void *unused) 
	/*

	 * This is icky, but we use this to simply ensure that all CPUs have

	 * context switched, regardless of whether they were previously running

	 * kernel or user code. This ensures that no CPU currently has its FPU

	 * enabled, or is about to attempt to enable it through any path other

	 * than enable_restore_fp_context() which will wait appropriately for

	 * fp_mode_switching to be zero.

	 * kernel or user code. This ensures that no CPU that a mode-switching

	 * program may execute on keeps its FPU enabled (& in the old mode)

	 * throughout the mode switch.

	 */

	return 0;

}
@@ -829,8 +828,6 @@ int mips_set_process_fp_mode(struct task_struct *task, unsigned int value) 
		work_on_cpu(cpu, prepare_for_fp_mode_switch, NULL);

	put_online_cpus();



	wake_up_var(&task->mm->context.fp_mode_switching);



	return 0;

}