Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41d3ae4b authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/powerplay: fix return codes in BACO code 



Use a proper return code rather than -1.

Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 94b94438

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c

+2 −2
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ int vega10_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state) 
		if (soc15_baco_program_registers(hwmgr, pre_baco_tbl,

					     ARRAY_SIZE(pre_baco_tbl))) {

			if (smum_send_msg_to_smc(hwmgr, PPSMC_MSG_EnterBaco))

				return -1;

				return -EINVAL;



			if (soc15_baco_program_registers(hwmgr, enter_baco_tbl,

						   ARRAY_SIZE(enter_baco_tbl)))
@@ -154,5 +154,5 @@ int vega10_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state) 
		}

	}



	return -1;

	return -EINVAL;

}

drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c

+3 −3
Original line number Diff line number Diff line
@@ -89,14 +89,14 @@ int vega20_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state) 




		if(smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_EnterBaco, 0))

			return -1;

			return -EINVAL;



	} else if (state == BACO_STATE_OUT) {

		if (smum_send_msg_to_smc(hwmgr, PPSMC_MSG_ExitBaco))

			return -1;

			return -EINVAL;

		if (!soc15_baco_program_registers(hwmgr, clean_baco_tbl,

						     ARRAY_SIZE(clean_baco_tbl)))

			return -1;

			return -EINVAL;

	}



	return 0;