Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41aff62b authored by Samasth Norway Ananda's avatar Samasth Norway Ananda Committed by Greg Kroah-Hartman
Browse files

tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() 



[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]

In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.

Signed-off-by: default avatarSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 97ad3fc4

tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c

+1 −0
Original line number Diff line number Diff line
@@ -1111,6 +1111,7 @@ unsigned int get_pkg_num(int cpu) 
	retval = fscanf(fp, "%d\n", &pkg);

	if (retval != 1)

		errx(1, "%s: failed to parse", pathname);

	fclose(fp);

	return pkg;

}