Commit 418ca6e6 authored Oct 19, 2023 by Mateusz Palczewski Committed by Greg Kroah-Hartman Nov 08, 2023

igb: Fix potential memory leak in igb_add_ethtool_nfc_entry



[ Upstream commit 8c0b48e01daba5ca58f939a8425855d3f4f2ed14 ]

Add check for return of igb_update_ethtool_nfc_entry so that in case
of any potential errors the memory alocated for input will be freed.

Fixes: 0e71def2 ("igb: add support of RX network flow classification")
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 00ef4a7d

drivers/net/ethernet/intel/igb/igb_ethtool.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2997,11 +2997,15 @@ static int igb_add_ethtool_nfc_entry(struct igb_adapter *adapter,
		if (err)
		goto err_out_w_lock;

		igb_update_ethtool_nfc_entry(adapter, input, input->sw_idx);
		err = igb_update_ethtool_nfc_entry(adapter, input, input->sw_idx);
		if (err)
		goto err_out_input_filter;

		spin_unlock(&adapter->nfc_lock);
		return 0;

		err_out_input_filter:
		igb_erase_filter(adapter, input);
		err_out_w_lock:
		spin_unlock(&adapter->nfc_lock);
		err_out: