Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 417b11d3 authored by Zubin Mithra's avatar Zubin Mithra Committed by Greg Kroah-Hartman
Browse files

ALSA: pcm: fix divide error in snd_pcm_lib_ioctl 



commit f3eef46f0518a2b32ca1244015820c35a22cfe4a upstream.

Syzkaller reported a divide error in snd_pcm_lib_ioctl. fifo_size
is of type snd_pcm_uframes_t(unsigned long). If frame_size
is 0x100000000, the error occurs.

Fixes: a9960e6a ("ALSA: pcm: fix fifo_size frame calculation")
Signed-off-by: default avatarZubin Mithra <zsm@chromium.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210827153735.789452-1-zsm@chromium.org


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf28619c

sound/core/pcm_lib.c

+1 −1
Original line number Diff line number Diff line
@@ -1736,7 +1736,7 @@ static int snd_pcm_lib_ioctl_fifo_size(struct snd_pcm_substream *substream, 
		channels = params_channels(params);

		frame_size = snd_pcm_format_size(format, channels);

		if (frame_size > 0)

			params->fifo_size /= (unsigned)frame_size;

			params->fifo_size /= frame_size;

	}

	return 0;

}