Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4109d9a8 authored by Denis Benato's avatar Denis Benato Committed by Greg Kroah-Hartman
Browse files

HID: hid-asus: add const to read-only outgoing usb buffer 



[ Upstream commit 06ae5afce8cc1f7621cc5c7751e449ce20d68af7 ]

In the function asus_kbd_set_report the parameter buf is read-only
as it gets copied in a memory portion suitable for USB transfer,
but the parameter is not marked as const: add the missing const and mark
const immutable buffers passed to that function.

Signed-off-by: default avatarDenis Benato <benato.denis96@gmail.com>
Signed-off-by: default avatarLuke D. Jones <luke@ljones.dev>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1fc40919

drivers/hid/hid-asus.c

+3 −3
Original line number Diff line number Diff line
@@ -336,7 +336,7 @@ static int asus_raw_event(struct hid_device *hdev, 
	return 0;

}



static int asus_kbd_set_report(struct hid_device *hdev, u8 *buf, size_t buf_size)

static int asus_kbd_set_report(struct hid_device *hdev, const u8 *buf, size_t buf_size)

{

	unsigned char *dmabuf;

	int ret;
@@ -355,7 +355,7 @@ static int asus_kbd_set_report(struct hid_device *hdev, u8 *buf, size_t buf_size 


static int asus_kbd_init(struct hid_device *hdev)

{

	u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54,

	const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54,

		     0x65, 0x63, 0x68, 0x2e, 0x49, 0x6e, 0x63, 0x2e, 0x00 };

	int ret;
@@ -369,7 +369,7 @@ static int asus_kbd_init(struct hid_device *hdev) 
static int asus_kbd_get_functions(struct hid_device *hdev,

				  unsigned char *kbd_func)

{

	u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x05, 0x20, 0x31, 0x00, 0x08 };

	const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x05, 0x20, 0x31, 0x00, 0x08 };

	u8 *readbuf;

	int ret;