Commit 40d23de5 authored Aug 24, 2021 by Shai Malin Committed by Greg Kroah-Hartman Sep 12, 2021

qede: Fix memset corruption



[ Upstream commit e543468869e2532f5d7926e8f417782b48eca3dc ]

Thanks to Kees Cook who detected the problem of memset that starting
from not the first member, but sized for the whole struct.
The better change will be to remove the redundant memset and to clear
only the msix_cnt member.

Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
Reported-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 468623f6

drivers/net/ethernet/qlogic/qede/qede_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1773,6 +1773,7 @@ static void qede_sync_free_irqs(struct qede_dev *edev)
		}

		edev->int_info.used_cnt = 0;
		edev->int_info.msix_cnt = 0;
		}

		static int qede_req_msix_irqs(struct qede_dev *edev)
		@@ -2317,7 +2318,6 @@ static int qede_load(struct qede_dev *edev, enum qede_load_mode mode,
		goto out;
		err4:
		qede_sync_free_irqs(edev);
		memset(&edev->int_info.msix_cnt, 0, sizeof(struct qed_int_info));
		err3:
		qede_napi_disable_remove(edev);
		err2: