Commit 408ef501 authored Jun 25, 2020 by Vasily Averin Committed by Greg Kroah-Hartman Jul 22, 2020

fuse: don't ignore errors from fuse_writepages_fill()



[ Upstream commit 7779b047a57f6824a43d0e1f70de2741b7426b9d ]

fuse_writepages() ignores some errors taken from fuse_writepages_fill() I
believe it is a bug: if .writepages is called with WB_SYNC_ALL it should
either guarantee that all data was successfully saved or return error.

Fixes: 26d614df ("fuse: Implement writepages callback")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9b810684

fs/fuse/file.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2148,10 +2148,8 @@ static int fuse_writepages(struct address_space *mapping,

		err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data);
		if (data.wpa) {
		/* Ignore errors if we can write at least one page */
		WARN_ON(!data.wpa->ia.ap.num_pages);
		fuse_writepages_send(&data);
		err = 0;
		}
		if (data.ff)
		fuse_file_put(data.ff, false, false);