Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4087a5f2 authored by Vaishali Thakkar's avatar Vaishali Thakkar Committed by Stephen Boyd
Browse files

clk: bcm/kona: Do not use sizeof on pointer type 



When sizeof is applied to a pointer typed expression, it gives
the size of the pointer. So, here do not use sizeof on pointer
type. Also, silent checkpatch.pl by using kmalloc_array over
kmalloc.

Note that this has no effect on runtime because 'parent_names'
is a pointer to a pointer.

Problem found using Coccinelle.

Signed-off-by: default avatarVaishali Thakkar <vaishali.thakkar@oracle.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 2a0974aa

drivers/clk/bcm/clk-kona-setup.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -577,7 +577,8 @@ static u32 *parent_process(const char *clocks[], 
	 * selector is not required, but we allocate space for the

	 * selector is not required, but we allocate space for the

	 * array anyway to keep things simple.

	 * array anyway to keep things simple.

	 */

	 */

	parent_names = kmalloc(parent_count * sizeof(parent_names), GFP_KERNEL);

	parent_names = kmalloc_array(parent_count, sizeof(*parent_names),

			       GFP_KERNEL);

	if (!parent_names) {

	if (!parent_names) {

		pr_err("%s: error allocating %u parent names\n", __func__,

		pr_err("%s: error allocating %u parent names\n", __func__,

				parent_count);

				parent_count);