Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 400a30dd authored by Geliang Tang's avatar Geliang Tang Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723au: fix static checker warning



Fix the following static checker warning:

 drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a()
 error: potential NULL dereference 'psta'.

Fixes: e280d71b("staging: rtl8723au: use list_for_each_entry*()")
Signed-off-by: default avatarGeliang Tang <geliangtang@163.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c15cc498
Loading
Loading
Loading
Loading
+4 −2
Original line number Original line Diff line number Diff line
@@ -346,7 +346,7 @@ void rtw_free_all_stainfo23a(struct rtw_adapter *padapter)
struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr)
struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr)
{
{
	struct list_head *phead;
	struct list_head *phead;
	struct sta_info *psta = NULL;
	struct sta_info *pos, *psta = NULL;
	u32 index;
	u32 index;
	const u8 *addr;
	const u8 *addr;


@@ -362,7 +362,9 @@ struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr)


	spin_lock_bh(&pstapriv->sta_hash_lock);
	spin_lock_bh(&pstapriv->sta_hash_lock);
	phead = &pstapriv->sta_hash[index];
	phead = &pstapriv->sta_hash[index];
	list_for_each_entry(psta, phead, hash_list) {
	list_for_each_entry(pos, phead, hash_list) {
		psta = pos;

		/*  if found the matched address */
		/*  if found the matched address */
		if (ether_addr_equal(psta->hwaddr, addr))
		if (ether_addr_equal(psta->hwaddr, addr))
			break;
			break;