Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fe6b49e authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

net_sched: cls_bpf: remove faulty use of list_for_each_entry_rcu 



rcu variant is not correct here. The code is called by updater (rtnl
lock is held), not by reader (no rcu_read_lock is held).

Signed-off-by: default avatarJiri Pirko <jiri@resnulli.us>
ACKed-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Acked-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 472f5837

net/sched/cls_bpf.c

+2 −2
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static unsigned long cls_bpf_get(struct tcf_proto *tp, u32 handle) 
	if (head == NULL)

		return 0UL;



	list_for_each_entry_rcu(prog, &head->plist, link) {

	list_for_each_entry(prog, &head->plist, link) {

		if (prog->handle == handle) {

			ret = (unsigned long) prog;

			break;
@@ -337,7 +337,7 @@ static void cls_bpf_walk(struct tcf_proto *tp, struct tcf_walker *arg) 
	struct cls_bpf_head *head = rtnl_dereference(tp->root);

	struct cls_bpf_prog *prog;



	list_for_each_entry_rcu(prog, &head->plist, link) {

	list_for_each_entry(prog, &head->plist, link) {

		if (arg->count < arg->skip)

			goto skip;

		if (arg->fn(tp, (unsigned long) prog, arg) < 0) {