Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fbaa3ac authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: clear the data field in ixgbe_read_i2c_byte_generic 



Clear the data field in ixgbe_read_i2c_byte_generic so it does not
accumulate 1 bit using the same variable multiple times.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 7edebf9a

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c

+2 −1
Original line number Diff line number Diff line
@@ -1205,7 +1205,7 @@ s32 ixgbe_write_i2c_eeprom_generic(struct ixgbe_hw *hw, u8 byte_offset, 
 *  @data: value read

 *

 *  Performs byte read operation to SFP module's EEPROM over I2C interface at

 *  a specified deivce address.

 *  a specified device address.

 **/

s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,

                                u8 dev_addr, u8 *data)
@@ -1215,6 +1215,7 @@ s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset, 
	u32 retry = 0;

	u16 swfw_mask = 0;

	bool nack = 1;

	*data = 0;



	if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)

		swfw_mask = IXGBE_GSSR_PHY1_SM;