Commit 3f9e88f2 authored Oct 29, 2024 by Jiri Kosina Committed by Greg Kroah-Hartman Nov 17, 2024

HID: core: zero-initialize the report buffer



[ Upstream commit 177f25d1292c7e16e1199b39c85480f7f8815552 ]

Since the report buffer is used by all kinds of drivers in various ways, let's
zero-initialize it during allocation to make sure that it can't be ever used
to leak kernel memory via specially-crafted report.

Fixes: 27ce4050 ("HID: fix data access in implement()")
Reported-by: Benoît Sevens <bsevens@google.com>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1e635487

drivers/hid/hid-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1657,7 +1657,7 @@ u8 hid_alloc_report_buf(struct hid_report report, gfp_t flags)

		u32 len = hid_report_len(report) + 7;

		return kmalloc(len, flags);
		return kzalloc(len, flags);
		}
		EXPORT_SYMBOL_GPL(hid_alloc_report_buf);