Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f2946a5 authored by Jerry Ray's avatar Jerry Ray Committed by Greg Kroah-Hartman
Browse files

net: lan9303: Fix read error execution path 



[ Upstream commit 8964916d206071b058c6351f88b1966bd58cbde0 ]

This patch fixes an issue where a read failure of a port statistic counter
will return unknown results.  While it is highly unlikely the read will
ever fail, it is much cleaner to return a zero for the stat count.

Fixes: a1292595 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
Signed-off-by: default avatarJerry Ray <jerry.ray@microchip.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20221209153502.7429-1-jerry.ray@microchip.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7d67e8cc

drivers/net/dsa/lan9303-core.c

+3 −1
Original line number Diff line number Diff line
@@ -1001,9 +1001,11 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port, 
		ret = lan9303_read_switch_port(

			chip, port, lan9303_mib[u].offset, &reg);



		if (ret)

		if (ret) {

			dev_warn(chip->dev, "Reading status port %d reg %u failed\n",

				 port, lan9303_mib[u].offset);

			reg = 0;

		}

		data[u] = reg;

	}

}