Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f22f9dd authored by Shreyas Deodhar's avatar Shreyas Deodhar Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Pointer may be dereferenced 



commit 00eca15319d9ce8c31cdf22f32a3467775423df4 upstream.

Klocwork tool reported pointer 'rport' returned from call to function
fc_bsg_to_rport() may be NULL and will be dereferenced.

Add a fix to validate rport before dereferencing.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarShreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-7-njavali@marvell.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a1c5149a

drivers/scsi/qla2xxx/qla_bsg.c

+2 −0
Original line number Diff line number Diff line
@@ -2530,6 +2530,8 @@ qla24xx_bsg_request(struct bsg_job *bsg_job) 


	if (bsg_request->msgcode == FC_BSG_RPT_ELS) {

		rport = fc_bsg_to_rport(bsg_job);

		if (!rport)

			return ret;

		host = rport_to_shost(rport);

		vha = shost_priv(host);

	} else {