Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ede0bbc authored Sep 19, 2018 by Robert Shearman Committed by David S. Miller Sep 19, 2018

ipv6: Allow the l3mdev to be a loopback



There is no way currently for an IPv6 client connect using a loopback
address in a VRF, whereas for IPv4 the loopback address can be added:

    $ sudo ip addr add dev vrfred 127.0.0.1/8
    $ sudo ip -6 addr add ::1/128 dev vrfred
    RTNETLINK answers: Cannot assign requested address

So allow ::1 to be configured on an L3 master device. In order for
this to be usable ip_route_output_flags needs to not consider ::1 to
be a link scope address (since oif == l3mdev and so it would be
dropped), and ipv6_rcv needs to consider the l3mdev to be a loopback
device so that it doesn't drop the packets.

Signed-off-by: Robert Shearman <rshearma@vyatta.att-mail.com>
Signed-off-by: Mike Manning <mmanning@vyatta.att-mail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1e6a4bc8

net/ipv6/addrconf.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -997,6 +997,7 @@ ipv6_add_addr(struct inet6_dev idev, struct ifa6_config cfg,
		if (addr_type == IPV6_ADDR_ANY \|\|
		addr_type & IPV6_ADDR_MULTICAST \|\|
		(!(idev->dev->flags & IFF_LOOPBACK) &&
		!netif_is_l3_master(idev->dev) &&
		addr_type & IPV6_ADDR_LOOPBACK))
		return ERR_PTR(-EADDRNOTAVAIL);

net/ipv6/ip6_input.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -178,7 +178,8 @@ static struct sk_buff ip6_rcv_core(struct sk_buff skb, struct net_device *dev,
		*/
		if ((ipv6_addr_loopback(&hdr->saddr) \|\|
		ipv6_addr_loopback(&hdr->daddr)) &&
		!(dev->flags & IFF_LOOPBACK))
		!(dev->flags & IFF_LOOPBACK) &&
		!netif_is_l3_master(dev))
		goto err;

		/* RFC4291 Errata ID: 3480

net/ipv6/route.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2071,7 +2071,8 @@ struct dst_entry ip6_route_output_flags(struct net net, const struct sock *sk,
		{
		bool any_src;

		if (rt6_need_strict(&fl6->daddr)) {
		if (ipv6_addr_type(&fl6->daddr) &
		(IPV6_ADDR_MULTICAST \| IPV6_ADDR_LINKLOCAL)) {
		struct dst_entry *dst;

		dst = l3mdev_link_scope_lookup(net, fl6);