Commit 3ead9578 authored Feb 12, 2014 by Li Zefan Committed by Brian Norris Mar 10, 2014

jffs2: remove from wait queue after schedule()

@wait is a local variable, so if we don't remove it from the wait queue
list, later wake_up() may end up accessing invalid memory.

This was spotted by eyes.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent f4f6a0be

fs/jffs2/nodemgmt.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -179,6 +179,7 @@ int jffs2_reserve_space(struct jffs2_sb_info *c, uint32_t minsize,
		spin_unlock(&c->erase_completion_lock);

		schedule();
		remove_wait_queue(&c->erase_wait, &wait);
		} else
		spin_unlock(&c->erase_completion_lock);
		} else if (ret)