Commit 3dd40cb3 authored Oct 03, 2017 by Josh Poimboeuf Committed by Ingo Molnar Oct 04, 2017

objtool: Upgrade libelf-devel warning to error for CONFIG_ORC_UNWINDER

With CONFIG_ORC_UNWINDER, if the user doesn't have libelf-devel
installed, and they don't see the make warning, their ORC unwinder will
be silently broken.  Upgrade the warning to an error.

Reported-and-tested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/d9dfc39fb8240998820f9efb233d283a1ee96084.1507079417.git.jpoimboe@redhat.com

Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent d81fa669

Makefile

+5 −1

Original line number	Original line	Diff line number	Diff line
	@@ -933,7 +933,11 @@ ifdef CONFIG_STACK_VALIDATION
	ifeq ($(has_libelf),1)		ifeq ($(has_libelf),1)
	objtool_target := tools/objtool FORCE		objtool_target := tools/objtool FORCE
	else		else
	$(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel")		ifdef CONFIG_ORC_UNWINDER
			$(error "Cannot generate ORC metadata for CONFIG_ORC_UNWINDER=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel")
			else
			$(warning "Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel")
			endif
	SKIP_STACK_VALIDATION := 1		SKIP_STACK_VALIDATION := 1
	export SKIP_STACK_VALIDATION		export SKIP_STACK_VALIDATION
	endif		endif