Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dd0f18c authored by Wei Yongjun's avatar Wei Yongjun Committed by Mimi Zohar
Browse files

EVM: fix return value check in evm_write_xattrs() 



In case of error, the function audit_log_start() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: fa516b66 ("EVM: Allow runtime modification of the set of verified xattrs")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarSerge Hallyn <serge@hallyn.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
parent 6eb864c1

security/integrity/evm/evm_secfs.c

+2 −2
Original line number Diff line number Diff line
@@ -193,8 +193,8 @@ static ssize_t evm_write_xattrs(struct file *file, const char __user *buf, 
		return -E2BIG;



	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_INTEGRITY_EVM_XATTR);

	if (IS_ERR(ab))

		return PTR_ERR(ab);

	if (!ab)

		return -ENOMEM;



	xattr = kmalloc(sizeof(struct xattr_list), GFP_KERNEL);

	if (!xattr) {