Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dc78932 authored by David S. Miller's avatar David S. Miller
Browse files

tcp: Remove runtime check that can never be true. 



GCC even warns about it, as reported by Andrew Morton:

net/ipv4/tcp.c: In function 'do_tcp_getsockopt':
net/ipv4/tcp.c:2544: warning: comparison is always false due to limited range of data type

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e61444d9

net/ipv4/tcp.c

+0 −5
Original line number Diff line number Diff line
@@ -2540,11 +2540,6 @@ static int do_tcp_getsockopt(struct sock *sk, int level, 
			ctd.tcpct_cookie_desired = cvp->cookie_desired;

			ctd.tcpct_s_data_desired = cvp->s_data_desired;



			/* Cookie(s) saved, return as nonce */

			if (sizeof(ctd.tcpct_value) < cvp->cookie_pair_size) {

				/* impossible? */

				return -EINVAL;

			}

			memcpy(&ctd.tcpct_value[0], &cvp->cookie_pair[0],

			       cvp->cookie_pair_size);

			ctd.tcpct_used = cvp->cookie_pair_size;