Commit 3dc03237 authored Apr 22, 2022 by Dongliang Mu Committed by Greg Kroah-Hartman Jun 14, 2022

media: ov7670: remove ov7670_power_off from ov7670_remove



[ Upstream commit 5bf19572e31375368f19edd2dbb2e0789518bb99 ]

In ov7670_probe, it always invokes ov7670_power_off() no matter
the execution is successful or failed. So we cannot invoke it
agiain in ov7670_remove().

Fix this by removing ov7670_power_off from ov7670_remove.

Fixes: 030f9f68 ("media: ov7670: control clock along with power")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dc794fa2

drivers/media/i2c/ov7670.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2000,7 +2000,6 @@ static int ov7670_remove(struct i2c_client *client)
		v4l2_async_unregister_subdev(sd);
		v4l2_ctrl_handler_free(&info->hdl);
		media_entity_cleanup(&info->sd.entity);
		ov7670_power_off(sd);
		return 0;
		}